Option for default presentations #965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want anything changed please let me know |
|
Hi, Thanks for this PR that we have been waiting a long time for. |
|
i would like to push this pull request, as this feature would help us a lot and we would love to see it merged in the official branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the option to supply default presentations on the
create-call. This is a good addition to the default params / override options.When submitting a
POST-request ascreate-call, the supplied body will be used. If there is no body supplied or it is initially aGET-request, the default presentations will be added.Testing Steps
Set the following inside your environment:
This will download the default BBB-presentation two times, with two different names to showcase the options.
->is the separator of URL and name because this is unlikely to appear inside an URL. Also with that, it is possible to addbase64-presentations in the future.